TYPING: add type hints to pandas\io\formats\printing.py #27579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Output-Formatting
pandas/io/formats/printing.py
Outdated
|
|
||
| from pandas._config import get_option | ||
|
|
||
| from pandas.core.dtypes.inference import is_sequence | ||
|
|
||
|
|
||
| def adjoin(space, *lists, **kwargs): | ||
| def adjoin(space: int, *lists: str, **kwargs) -> str: |
There was a problem hiding this comment.
Does this mean all the lists are strings?
There was a problem hiding this comment.
nice catch. should be List[str]. will update.
pandas/io/formats/printing.py
Outdated
| sep = str(sep) | ||
| return sep.join([x.decode("utf-8") if isinstance(x, str) else x for x in lines]) | ||
| def _join_unicode(lines: Iterable[str], sep: str = "") -> str: | ||
| return sep.join(lines) |
There was a problem hiding this comment.
only used in two places. inline and remove?
|
lgtm. @WillAyd |
WillAyd
approved these changes
Jul 25, 2019
| if hasattr(obj, "dtype") and include_dtype: | ||
| attrs.append(("dtype", "'{}'".format(obj.dtype))) | ||
| # error: "Sequence[Any]" has no attribute "dtype" |
There was a problem hiding this comment.
Hmm this type of introspection is going to be interesting with annotations. Something to think about moving forward
There was a problem hiding this comment.
see python/mypy#1424
|
Thanks @simonjayhawkins ! |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.