BUG: Add mapping for pyqt for successful package installation #27645
Conversation
charlesdong1991
changed the title
There was a problem hiding this comment.
I don't think this change has fixed things. You should run python scripts/generate_pip_deps_from_conda.py, which will update requirements-dev.txt, and commit that change.
It looks like the renaming may be skipped when there's no version pin, but I haven't looked closely.
doc/source/whatsnew/v0.25.1.rst
Outdated
| @@ -157,7 +157,7 @@ ExtensionArray | |||
| Other | |||
| ^^^^^ | |||
|
|
|||
| - | |||
| - Add pyqt in RENAME dictionary in `generate_pip_deps_from_conda.py` to fix installation failure of pandas (:issue:`26838`) | |||
There was a problem hiding this comment.
Referencing generate_pip_deps_from_conda.py probably isn't relevant to users. Let's just write this as "Fixed pyqt development dependency."
This doesn't need to be back ported, so you can remove the release note or move it to 1.0.0.rst
|
Merged master to fix the CI issue. Ping on green. |
|
ehh, how could I merge and resumbit the PR, the request of merge got rejected because there is a remote branch? shall i just do |
|
Git pull, and then git merge with this remote branch.
… On Aug 5, 2019, at 03:46, Kaiqi Dong ***@***.***> wrote:
ehh, how could I merge and resumbit the PR, the request of merge got rejected because there is a remote branch? shall i just do git pull and push to master? or do git pull remote_branch_name, but i dont know the remote branch name? I am not sure how to do it probably, and really would like to learn how ^^ @TomAugspurger
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
thanks @TomAugspurger will try later! |
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -186,6 +186,7 @@ Sparse | |||
|
|
|||
| Build Changes | |||
| ^^^^^^^^^^^^^ | |||
| - Fixed pyqt development dependency (:issue:`26838`) | |||
There was a problem hiding this comment.
can you be a little more specific here; IOW what would someone reading these notes need to know about this change
There was a problem hiding this comment.
yeah, make sense, will change later today! @jreback
There was a problem hiding this comment.
as well as that typo
|
this passed checks too ^^ @jreback |
|
any follow up? |
|
Thanks @charlesdong1991! |
…-dev#27645) * Add mapping for pyqt
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff