Skip to content

DOC: Fixing flake8 error in basics.rst #27981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

iamshreeram
Copy link

@iamshreeram iamshreeram changed the title Adding examples for pipe() to fix F821 flake8 error in basics.rst DOC: Fixing flake8 error in basics.rst Aug 18, 2019
@gfyoung gfyoung added Docs Code Style Code style, linting, code_checks labels Aug 18, 2019
@gfyoung gfyoung requested a review from datapythonista August 18, 2019 04:22
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @iamshreeram.

My preference would be to find something that looks like a real example, not those h, g,... abstract functions. I think to most people (at least surely myself), understanding the point of that example is not that easy, and it's not obvious to imagine a case where you'd want to use that. I think with something that looks like real data, and real transformations will be much easier.

It's not easy (that's why this hasn't been fixed yet), but surely doable.

Thanks!

@WillAyd
Copy link
Member

WillAyd commented Sep 5, 2019

Hi @iamshreeram - can you merge master and address comment?

@iamshreeram
Copy link
Author

Sure @WillAyd . I will work on it.

@jreback
Copy link
Contributor

jreback commented Oct 6, 2019

can you merge master

@datapythonista
Copy link
Member

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix all flake8 issues and warning in the documentation pages
5 participants