Skip to content

DataFrame html repr: also follow min_rows setting #27991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2019
Merged

DataFrame html repr: also follow min_rows setting #27991

merged 2 commits into from
Aug 20, 2019

Conversation

jorisvandenbossche
Copy link
Member

Follow-up on #27095, where I forgot to apply this setting in the html repr as well.

Thoughts on including this in 0.25.1 or not? It's kind of a oversight of the 0.25 feature, but also an actual change of course in the user experience in the notebook.

@simonjayhawkins simonjayhawkins added IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string labels Aug 19, 2019
@TomAugspurger
Copy link
Contributor

I'm probably OK with backporting 0.25.1.

@jorisvandenbossche jorisvandenbossche added this to the 0.25.1 milestone Aug 19, 2019
@jorisvandenbossche
Copy link
Member Author

OK, added a whatsnew for 0.25.1 then

@TomAugspurger TomAugspurger merged commit ec3d786 into pandas-dev:master Aug 20, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 20, 2019
@jorisvandenbossche
Backport PR pandas-dev#27991: DataFrame html repr: also follow min_ro…
db224d7 
…ws setting
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 20, 2019
Merged
jorisvandenbossche pushed a commit that referenced this pull request Aug 21, 2019
@meeseeksmachine @jorisvandenbossche
Backport PR #27991 on branch 0.25.x (DataFrame html repr: also follow…
8795cb7 
… min_rows setting) (#28044)

* Backport PR #27991: DataFrame html repr: also follow min_rows setting

* fix return value
galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
@jorisvandenbossche @galuhsahid
DataFrame html repr: also follow min_rows setting (pandas-dev#27991)
20716ce 
* DataFrame html repr: also follow min_rows setting

* add whatsnew
This was referenced Aug 29, 2019
Closed
Merged
@greglandrum greglandrum mentioned this pull request Jan 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @TomAugspurger @simonjayhawkins