TST: Parametrize and cleanup Exception #28478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Sep 17, 2019
pandas/tests/frame/test_indexing.py
Outdated
| repr(df) | ||
| except Exception as e: | ||
| assert type(e) != UnboundLocalError | ||
| # Note: this used to be a test that any exception that _is_ |
There was a problem hiding this comment.
Should just delete altogether? Maybe missing the point but I don't see what this was testing previously
There was a problem hiding this comment.
pandas/tests/test_expressions.py
Outdated
| @@ -332,78 +331,81 @@ def testit(): | |||
| expr.set_numexpr_threads() | |||
| testit() | |||
|
|
|||
| def test_bool_ops_raise_on_arithmetic(self): | |||
| @pytest.mark.parametrize( | |||
| "op,name", list(zip(["/", "//", "**"], ["truediv", "floordiv", "pow"])) | |||
There was a problem hiding this comment.
I think would be nicer to follow the opname, op_str convention for consistency
pandas/tests/test_expressions.py
Outdated
|
|
||
| def test_bool_ops_warn_on_arithmetic(self): | ||
| @pytest.mark.parametrize( | ||
| "op,name", list(zip(["+", "*", "-"], ["add", "mul", "sub"])) |
pandas/tests/test_expressions.py
Outdated
| f = getattr(operator, name) | ||
| fe = getattr(operator, sub_funcs[subs[op]]) | ||
|
|
||
| if op == "-": |
There was a problem hiding this comment.
Does this even need to be parametrized if we just return?
There was a problem hiding this comment.
I'm planning on re-visiting this in an upcoming pass to see if it can be made viable.
TomAugspurger
approved these changes
Sep 17, 2019
| @@ -332,78 +331,81 @@ def testit(): | |||
| expr.set_numexpr_threads() | |||
| testit() | |||
|
|
|||
| def test_bool_ops_raise_on_arithmetic(self): | |||
| @pytest.mark.parametrize( | |||
| "op_str,opname", list(zip(["/", "//", "**"], ["truediv", "floordiv", "pow"])) | |||
There was a problem hiding this comment.
Do you find list(zip(...) clearer than writing out the pairs?
[('/', 'truediv'), ...]There was a problem hiding this comment.
Good idea. Will change in next pass.
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.