DEV: skip pandas/__init__.py in isort's pre-commit hook #28517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tracking this down. I wondered why the config was being ignored. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…8517) * DEV: skip pandas/__init__.py in isort's pre-commit hook * also add core api
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…8517) * DEV: skip pandas/__init__.py in isort's pre-commit hook * also add core api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when you modified
pandas/__init__.py, isort actually completely reordered it when using pre-commit hook. Apparantly, isort ignores the skip config when you explicitly pass a path to isort (pre-commit basically doesisort pandas/__init__.pywhen that file changed).See pre-commit/mirrors-isort#9, which suggested to add this exclude to the pre-commit config (although that duplicates the "skip" information from setup.cfg)