Skip to content

read_hdf closes HDF5 stores that it didn't open.#28700

Merged
WillAyd merged 5 commits into
pandas-dev:masterfrom
kboone:master
Oct 10, 2019
Merged

read_hdf closes HDF5 stores that it didn't open.#28700
WillAyd merged 5 commits into
pandas-dev:masterfrom
kboone:master

Conversation

@kboone

@kboone kboone commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

This commit fixes #28699. I added a test for the bug.

@kboone

kboone commented Oct 1, 2019

Copy link
Copy Markdown
Contributor Author

I'm not entirely sure why these checks failed. It looks like there is some major reorganization of test_pytables.py happening right now?

@jbrockmendel

Copy link
Copy Markdown
Member

Can you rebase?

I'm not aware of a major reorganization of the file, but there was a recent change that removed an except Exception: that may be causing the merge conflict.

@kboone

kboone commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Looks like how paths are created was changed in test_pytables.py yesterday which created some conflicts. I updated my test to the new format and rebased.

@kboone

kboone commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Got it sorted out. The previous error was due to me using single quotes somewhere rather than double quotes, and black pandas didn't like that.

@jreback jreback added the IO HDF5 read_hdf, HDFStore label Oct 3, 2019
@jreback jreback added this to the 1.0 milestone Oct 3, 2019
@jreback

jreback commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

lgtm. can you add a whatsnew note in bugfix of 1.0.0 for IO section. note that I am about to merge a refactor of the pytables tests, so will have to rebase on master (but shouldn't be a conflict i think).

@jreback jreback mentioned this pull request Oct 3, 2019
5 tasks
@kboone

kboone commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

I updated the whatsnew for 1.0.0. Let me know if I need to change anything for the refactor of the pytables tests.

@jreback

jreback commented Oct 5, 2019

Copy link
Copy Markdown
Contributor

can you merge master, we moved some tests around

@kboone

kboone commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

I merged master and resolved the conflicts.

@WillAyd
WillAyd merged commit 959a760 into pandas-dev:master Oct 10, 2019
@WillAyd

WillAyd commented Oct 10, 2019

Copy link
Copy Markdown
Member

Thanks @kboone !

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO HDF5 read_hdf, HDFStore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_hdf closes HDF5 stores that it didn't open.

4 participants