-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
read_hdf closes HDF5 stores that it didn't open. #28700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not entirely sure why these checks failed. It looks like there is some major reorganization of test_pytables.py happening right now? |
Can you rebase? I'm not aware of a major reorganization of the file, but there was a recent change that removed an |
Looks like how paths are created was changed in test_pytables.py yesterday which created some conflicts. I updated my test to the new format and rebased. |
Got it sorted out. The previous error was due to me using single quotes somewhere rather than double quotes, and black pandas didn't like that. |
lgtm. can you add a whatsnew note in bugfix of 1.0.0 for IO section. note that I am about to merge a refactor of the pytables tests, so will have to rebase on master (but shouldn't be a conflict i think). |
I updated the whatsnew for 1.0.0. Let me know if I need to change anything for the refactor of the pytables tests. |
can you merge master, we moved some tests around |
I merged master and resolved the conflicts. |
Thanks @kboone ! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
This commit fixes #28699. I added a test for the bug.