Skip to content

DOC: fix pr09,pr08 errors in frame.py #28728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

josibake
Copy link

@josibake josibake commented Oct 1, 2019

fixing methods defined in this file
this is part of a larger clean up of
the dataframe class

this fixes a subset of #28702

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Josiah Baker added 2 commits October 1, 2019 11:19
fixing methods defined in this file
this is part of a larger clean up of
the dataframe class
if its on the next line, the validation script doesnt
know to remove it before checking for periods
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green

@WillAyd WillAyd added the Docs label Oct 1, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 1, 2019
@WillAyd WillAyd merged commit b104954 into pandas-dev:master Oct 1, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2019

Thanks @josibake

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants