CLN: dont catch Exception in groupby var #28883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Oct 10, 2019
| @@ -721,6 +722,10 @@ def f(g): | |||
| with np.errstate(all="ignore"): | |||
| return func(g, *args, **kwargs) | |||
|
|
|||
| elif hasattr(nanops, "nan" + func): | |||
| # TODO: should we wrap this in to e.g. _is_builtin_func? | |||
There was a problem hiding this comment.
That would seem logical; follow ups to figure out what is actually needed here are certainly welcome
WillAyd
added
Clean
Error Reporting
WillAyd
approved these changes
Oct 10, 2019
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between this, #28878, and #28873, I'm finding that the outside-in approach to cleaning this up is proving easier the earlier inside-out approach.