Skip to content

DOC: disable nbsphinx including requirejs #28940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

To fix pydata/pydata-sphinx-theme#25. With their latest release, nbsphinx started including require.js by default, which doesn't play nice with the bootstrap.js (and as a result, no javascript at all works).
This is using an option of nbsphinx to not include requirejs (which we don't need, nbsphinx added this for rendering notebooks with plotly, I think)

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Oct 12, 2019
@jorisvandenbossche jorisvandenbossche merged commit f7d162b into pandas-dev:master Oct 12, 2019
@jorisvandenbossche jorisvandenbossche deleted the doc-nsphinx-bootstrap branch October 12, 2019 18:04
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In mobile the navigation menu does not open
1 participant