Skip to content

Change width of specific columns using col_space param in df.to_html #28950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SRIRAM777
Copy link

@SRIRAM777 SRIRAM777 commented Oct 13, 2019

DataFrame.to_html col_space parameter to change width of a specific column only

DataFrame.to_html col_space parameter to change width of a specific column only
@pep8speaks
Copy link

Hello @SRIRAM777! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 128:89: E501 line too long (99 > 88 characters)
Line 130:89: E501 line too long (92 > 88 characters)

@simonjayhawkins
Copy link
Member

@SRIRAM777 there is already a PR for this, see #28929.

@SRIRAM777
Copy link
Author

@SRIRAM777 there is already a PR for this, see #28929.

Hi @simonjayhawkins Since you had requested to avoid the usage of an additional argument in that PR, I thought of utilizing the existing argument col_space to accept dict values like {'col1':25,'col2':50} to handle column width for specific columns. I'm new to open source contribution. Am I not supposed to raise another PR when there's already one?

@simonjayhawkins
Copy link
Member

we don't encourage competing PRs. The other PR is not stale. The OP is awaiting some clarification on the requirements. If you could review that PR and make suggestions, that'll be great.

@SRIRAM777
Copy link
Author

we don't encourage competing PRs. The other PR is not stale. The OP is awaiting some clarification on the requirements. If you could review that PR and make suggestions, that'll be great.

@simonjayhawkins Sorry about that. So, should I close this one?

@simonjayhawkins
Copy link
Member

So, should I close this one?

for now, that's probably best.

Thanks for taking the time to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.to_html col_space parameter to change width of a specific column only
3 participants