Skip to content

CLN: Add type hinting to base classes (#28926) #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjlkant wants to merge 5 commits into from
Closed

CLN: Add type hinting to base classes (#28926) #28983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4046de
Merge pull request #1 from pandas-dev/master
jjlkant Oct 14, 2019
871971b
Merge remote-tracking branch 'upstream/master'
jjlkant Oct 14, 2019
235a8be
CLN: Add type hinting in base classes (GH28926)
jjlkant Oct 14, 2019
b03a214
CLN: Added type hints to test classes (GH28926)
jjlkant Oct 14, 2019
a61126b
Merge upstream/master
jjlkant Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from datetime import date, datetime, time
from io import StringIO
import sqlite3
from typing import Optional
import warnings

import numpy as np
Expand Down Expand Up @@ -583,7 +584,7 @@ class _TestSQLApi(PandasSQLTest):
"""

flavor = "sqlite"
mode = None
mode = None # type: Optional[str]

def setup_connect(self):
self.conn = self.connect()
Expand Down Expand Up @@ -1234,7 +1235,7 @@ class _TestSQLAlchemy(SQLAlchemyMixIn, PandasSQLTest):

"""

flavor = None
flavor = None # type: Optional[str]

@pytest.fixture(autouse=True, scope="class")
def setup_class(cls):
Expand Down Expand Up @@ -1837,7 +1838,7 @@ class _TestSQLiteAlchemy:

"""

flavor = "sqlite"
flavor = "sqlite" # type: Optional[str]

@classmethod
def connect(cls):
Expand Down Expand Up @@ -1886,7 +1887,7 @@ class _TestMySQLAlchemy:

"""

flavor = "mysql"
flavor = "mysql" # type: Optional[str]

@classmethod
def connect(cls):
Expand Down Expand Up @@ -1955,7 +1956,7 @@ class _TestPostgreSQLAlchemy:

"""

flavor = "postgresql"
flavor = "postgresql" # type: Optional[str]

@classmethod
def connect(cls):
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,6 @@ ignore_errors=True
[mypy-pandas.tests.io.json.test_ujson]
ignore_errors=True

[mypy-pandas.tests.io.test_sql]
ignore_errors=True

[mypy-pandas.tests.plotting.test_backend]
ignore_errors=True

Expand Down