Skip to content

BUG: parse_time_string failing to raise TypeError #29098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2019

Conversation

jbrockmendel
Copy link
Member

Cleans up one of the TODOs introduced in recent groupby work.

Adds some type annotations along the way.

@jreback jreback added the Clean label Oct 19, 2019
@jreback jreback added this to the 1.0 milestone Oct 19, 2019
@jreback
Copy link
Contributor

jreback commented Oct 19, 2019

lgtm. ping on green.

side issue, can you fix the allowed failure test on travis that is an html test failure (xfail or remove the test).

@jbrockmendel
Copy link
Member Author

Ping

Will look at the Travis thing, likely Monday

@jreback jreback merged commit 04893a9 into pandas-dev:master Oct 19, 2019
@jreback
Copy link
Contributor

jreback commented Oct 19, 2019

thxs

@jbrockmendel jbrockmendel deleted the faster40 branch October 19, 2019 18:30
HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants