Skip to content

DOC: Fix SS06 formatting errors in Styler docstrings #29283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2019
Merged

DOC: Fix SS06 formatting errors in Styler docstrings #29283

merged 5 commits into from
Oct 31, 2019

Conversation

ShaharNaveh
Copy link
Member

Errors fixed (from the list in #29254 ):
pandas.io.formats.style.Styler.from_custom_template
pandas.io.formats.style.Styler.apply
pandas.io.formats.style.Styler.applymap
pandas.io.formats.style.Styler.set_properties
pandas.io.formats.style.Styler.clear
pandas.io.formats.style.Styler.background_gradient
pandas.io.formats.style.Styler.use
pandas.io.formats.style.Styler.where

Validated the fixes with python scripts/validate_docstrings.py
Refrencing issue: #29254

Errors fixed:
pandas.io.formats.style.Styler.from_custom_template
pandas.io.formats.style.Styler.apply
pandas.io.formats.style.Styler.applymap
pandas.io.formats.style.Styler.set_properties
pandas.io.formats.style.Styler.clear
pandas.io.formats.style.Styler.background_gradient
pandas.io.formats.style.Styler.use
pandas.io.formats.style.Styler.where
@jreback jreback added the Docs label Oct 30, 2019
@jreback jreback added this to the 1.0 milestone Oct 30, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammatical things but otherwise lgtm

@ShaharNaveh
Copy link
Member Author

ShaharNaveh commented Oct 31, 2019

@WillAyd Ty so much for the corrections. Not taken for granted the fact you literally marked the problems, Instead of just saying that there's grammer errors.

@ShaharNaveh ShaharNaveh requested a review from WillAyd October 31, 2019 07:01
@jorisvandenbossche jorisvandenbossche changed the title Fix SS06 formatting errors DOC: Fix SS06 formatting errors in Styler docstrings Oct 31, 2019
@jorisvandenbossche jorisvandenbossche merged commit 932f04e into pandas-dev:master Oct 31, 2019
@ShaharNaveh ShaharNaveh deleted the fix-ss06-issues branch October 31, 2019 10:05
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants