-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Fix SS06 formatting errors in Styler docstrings #29283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 5 commits into
pandas-dev:master
from
ShaharNaveh:fix-ss06-issues
Oct 31, 2019
Merged
DOC: Fix SS06 formatting errors in Styler docstrings #29283
jorisvandenbossche
merged 5 commits into
pandas-dev:master
from
ShaharNaveh:fix-ss06-issues
Oct 31, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors fixed: pandas.io.formats.style.Styler.from_custom_template pandas.io.formats.style.Styler.apply pandas.io.formats.style.Styler.applymap pandas.io.formats.style.Styler.set_properties pandas.io.formats.style.Styler.clear pandas.io.formats.style.Styler.background_gradient pandas.io.formats.style.Styler.use pandas.io.formats.style.Styler.where
WillAyd
requested changes
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor grammatical things but otherwise lgtm
Co-Authored-By: William Ayd <[email protected]>
Co-Authored-By: William Ayd <[email protected]>
Co-Authored-By: William Ayd <[email protected]>
Co-Authored-By: William Ayd <[email protected]>
@WillAyd Ty so much for the corrections. Not taken for granted the fact you literally marked the problems, Instead of just saying that there's grammer errors. |
gfyoung
approved these changes
Oct 31, 2019
jorisvandenbossche
approved these changes
Oct 31, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
Co-Authored-By: William Ayd <[email protected]>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Co-Authored-By: William Ayd <[email protected]>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Co-Authored-By: William Ayd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors fixed (from the list in #29254 ):
pandas.io.formats.style.Styler.from_custom_template
pandas.io.formats.style.Styler.apply
pandas.io.formats.style.Styler.applymap
pandas.io.formats.style.Styler.set_properties
pandas.io.formats.style.Styler.clear
pandas.io.formats.style.Styler.background_gradient
pandas.io.formats.style.Styler.use
pandas.io.formats.style.Styler.where
Validated the fixes with
python scripts/validate_docstrings.py
Refrencing issue: #29254