Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Implement Kleene logic for BooleanArray #29842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement Kleene logic for BooleanArray #29842
Changes from all commits
bb904cb
13c7ea3
fff786f
4067e7f
708c553
c56894e
2e9d547
373aaab
7f78a64
36b171b
747e046
d0a8cca
fe061b0
9f9e44c
0a34257
2ba0034
2d1129a
a24fc22
77dd1fc
7b9002c
c18046b
1237caa
2ecf9b8
87aeb09
969b6dc
1c9ba49
8eec954
cb47b6a
2a946b9
efb6f8b
004238e
5a2c81c
7032318
bbb7f9b
ce763b4
5bc5328
457bd08
31c2bc6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to convert to a python bool? why not just
bool(other)
?item
i usually think of as being an array methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
is the general method to get a python scalar (here we of course know we want a bool).But Tom, why is it exactly needed to convert this? I would think the numpy operations later on work fine with a numpy scalar as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, we do things like
if right is False
orif right is True
, which will fail for numpy booleans. I don't want to have to worry about checking both, so easier to convert here.