CLN: Update old .format to f-string #30547
Conversation
Reviewed and updated to f-string for: pandas/compat/pickle_compat.py pandas/_config/config.py pandas/core/arrays/boolean.py Contributes to GH29547
There was a problem hiding this comment.
Couple of comments, other than that looks good. Thanks @thepaullee
pandas/_config/config.py
Outdated
|
|
||
| for i, p in enumerate(path[:-1]): | ||
| if not isinstance(cursor, dict): | ||
| raise OptionError(msg.format(option=".".join(path[:i]))) | ||
| raise OptionError( | ||
| f"Path prefix to option '{'.'.join(path[:i])}' is already an option" |
There was a problem hiding this comment.
I think @jbrockmendel prefers to define expressions like this in a variable first, instead of using them directly in the f-string.
There was a problem hiding this comment.
yes i do. thanks for keeping an eye out
There was a problem hiding this comment.
my preference would be to leave the .format syntax when message used more than once to help ensure consistency of error messages.
There was a problem hiding this comment.
Reverted to the original .format syntax, but will keep the earlier comments in mind for the future!
pandas/core/arrays/boolean.py
Outdated
| "'other' should be pandas.NA or a bool. Got {} instead.".format( | ||
| type(other).__name__ | ||
| ) | ||
| f"'other' should be pandas.NA or a bool.\ |
There was a problem hiding this comment.
We avoid backslashes in general, you can close the string here, and start it again in the next line, and they'll concatenate. Just leave a space at the end of this first string, and just make the second a f-string.
There was a problem hiding this comment.
Good to know, done!
Co-Authored-By: Marc Garcia <[email protected]>
|
Thanks @thepaullee |
Reviewed and updated to f-string for:
pandas/compat/pickle_compat.py
pandas/_config/config.py
pandas/core/arrays/boolean.py
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffMarking pickle_compat.py as done but I left the existing
.formatas is, as I believe this is a good use case for.format