-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: Removed "# noqa: F401" comments #30832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,27 @@ | ||
| """Public API for extending pandas objects.""" | ||
| from pandas._libs.lib import no_default # noqa: F401 | ||
| """ | ||
| Public API for extending pandas objects. | ||
| """ | ||
|
|
||
| from pandas.core.dtypes.dtypes import ( # noqa: F401 | ||
| ExtensionDtype, | ||
| register_extension_dtype, | ||
| ) | ||
| from pandas._libs.lib import no_default | ||
|
|
||
| from pandas.core.dtypes.dtypes import ExtensionDtype, register_extension_dtype | ||
|
|
||
| from pandas.core.accessor import ( # noqa: F401 | ||
| from pandas.core.accessor import ( | ||
| register_dataframe_accessor, | ||
| register_index_accessor, | ||
| register_series_accessor, | ||
| ) | ||
| from pandas.core.algorithms import take # noqa: F401 | ||
| from pandas.core.arrays import ExtensionArray, ExtensionScalarOpsMixin # noqa: F401 | ||
| from pandas.core.algorithms import take | ||
| from pandas.core.arrays import ExtensionArray, ExtensionScalarOpsMixin | ||
|
|
||
| __all__ = [ | ||
| "no_default", | ||
| "ExtensionDtype", | ||
| "register_extension_dtype", | ||
| "register_dataframe_accessor", | ||
| "register_index_accessor", | ||
| "register_series_accessor", | ||
| "take", | ||
| "ExtensionArray", | ||
| "ExtensionScalarOpsMixin", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| """Public API for Rolling Window Indexers""" | ||
| from pandas.core.indexers import check_bool_array_indexer # noqa: F401 | ||
| from pandas.core.window.indexers import BaseIndexer # noqa: F401 | ||
| """ | ||
| Public API for Rolling Window Indexers. | ||
| """ | ||
|
|
||
| from pandas.core.indexers import check_bool_array_indexer | ||
| from pandas.core.window.indexers import BaseIndexer | ||
|
|
||
| __all__ = ["check_bool_array_indexer", "BaseIndexer"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,23 @@ | ||
| """ public toolkit API """ | ||
| """ | ||
| Public toolkit API. | ||
| """ | ||
|
|
||
| from pandas._libs.lib import infer_dtype # noqa: F401 | ||
| from pandas._libs.lib import infer_dtype | ||
|
|
||
| from pandas.core.dtypes.api import * # noqa: F403, F401 | ||
| from pandas.core.dtypes.concat import union_categoricals # noqa: F401 | ||
| from pandas.core.dtypes.dtypes import ( # noqa: F401 | ||
| from pandas.core.dtypes.concat import union_categoricals | ||
| from pandas.core.dtypes.dtypes import ( | ||
| CategoricalDtype, | ||
| DatetimeTZDtype, | ||
| IntervalDtype, | ||
| PeriodDtype, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "infer_dtype", | ||
| "union_categoricals", | ||
| "CategoricalDtype", | ||
| "DatetimeTZDtype", | ||
| "IntervalDtype", | ||
| "PeriodDtype", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,36 @@ | ||
| from pandas.core.arrays.base import ( # noqa: F401 | ||
| from pandas.core.arrays.base import ( | ||
| ExtensionArray, | ||
| ExtensionOpsMixin, | ||
| ExtensionScalarOpsMixin, | ||
| try_cast_to_ea, | ||
| ) | ||
| from pandas.core.arrays.boolean import BooleanArray # noqa: F401 | ||
| from pandas.core.arrays.categorical import Categorical # noqa: F401 | ||
| from pandas.core.arrays.datetimes import DatetimeArray # noqa: F401 | ||
| from pandas.core.arrays.integer import IntegerArray, integer_array # noqa: F401 | ||
| from pandas.core.arrays.interval import IntervalArray # noqa: F401 | ||
| from pandas.core.arrays.numpy_ import PandasArray, PandasDtype # noqa: F401 | ||
| from pandas.core.arrays.period import PeriodArray, period_array # noqa: F401 | ||
| from pandas.core.arrays.sparse import SparseArray # noqa: F401 | ||
| from pandas.core.arrays.string_ import StringArray # noqa: F401 | ||
| from pandas.core.arrays.timedeltas import TimedeltaArray # noqa: F401 | ||
| from pandas.core.arrays.boolean import BooleanArray | ||
| from pandas.core.arrays.categorical import Categorical | ||
| from pandas.core.arrays.datetimes import DatetimeArray | ||
| from pandas.core.arrays.integer import IntegerArray, integer_array | ||
| from pandas.core.arrays.interval import IntervalArray | ||
| from pandas.core.arrays.numpy_ import PandasArray, PandasDtype | ||
| from pandas.core.arrays.period import PeriodArray, period_array | ||
| from pandas.core.arrays.sparse import SparseArray | ||
| from pandas.core.arrays.string_ import StringArray | ||
| from pandas.core.arrays.timedeltas import TimedeltaArray | ||
|
|
||
| __all__ = [ | ||
| "ExtensionArray", | ||
| "ExtensionOpsMixin", | ||
| "ExtensionScalarOpsMixin", | ||
| "try_cast_to_ea", | ||
| "BooleanArray", | ||
| "Categorical", | ||
| "DatetimeArray", | ||
| "IntegerArray", | ||
| "integer_array", | ||
| "IntervalArray", | ||
| "PandasArray", | ||
| "PandasDtype", | ||
| "PeriodArray", | ||
| "period_array", | ||
| "SparseArray", | ||
| "StringArray", | ||
| "TimedeltaArray", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| from pandas.core.groupby.generic import ( # noqa: F401 | ||
| DataFrameGroupBy, | ||
| NamedAgg, | ||
| SeriesGroupBy, | ||
| ) | ||
| from pandas.core.groupby.groupby import GroupBy # noqa: F401 | ||
| from pandas.core.groupby.grouper import Grouper # noqa: F401 | ||
| from pandas.core.groupby.generic import DataFrameGroupBy, NamedAgg, SeriesGroupBy | ||
| from pandas.core.groupby.groupby import GroupBy | ||
| from pandas.core.groupby.grouper import Grouper | ||
|
|
||
| __all__ = [ | ||
| "DataFrameGroupBy", | ||
| "NamedAgg", | ||
| "SeriesGroupBy", | ||
| "GroupBy", | ||
| "Grouper", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jbrockmendel was this function added here recently?
I think
check_bool_array_indexeris conceptually different from what should belong in this file. Thisapi.indexerswas intended to be for creating indexers to supportrolling,groupbyetc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a recent PR by @TomAugspurger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was added in #30308. See the conversation starting around #30308 (comment). Do you have a better home you'd recommend @mroeschke?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the method seems ExtensionArray related, thought it could have belonged in
api.extensions.Agreed that
api.indexersisn't the best name. I can put in a PR tonight clarifying (e.g.api.grouping_indexersor something)