-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Encourage use of pre-commit in the docs #30864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Encourage use of pre-commit in the docs #30864
Conversation
abe5a82
to
b01b99b
Compare
b01b99b
to
087c704
Compare
lgtm. Having not really use pre-commit that much does it also play nicely with VSCode? Probably the route most first-time contributors come through so just want to make sure it doesn't add complications there |
Previously, we stated it as merely optional.
087c704
to
73ab6ef
Compare
What possible complications do you think of? I suppose if you have black auto-formatting enabled in vscode, you could run into problems with different configurations? |
You can disable plugins by workspace in VSCode, so I wouldn't consider this an issue. https://code.visualstudio.com/docs/editor/extension-gallery#_disable-an-extension |
…ndexing-1row-df * upstream/master: (284 commits) CLN: leftover ix checks (pandas-dev#30951) CI: numpydev changed double to single quote (pandas-dev#30952) DOC: Fix whatsnew contributors section (pandas-dev#30926) STY: wrong placed space in strings (pandas-dev#30940) TYP: type up parts of series.py (pandas-dev#30761) DOC: Fix SS03 docstring error (pandas-dev#30939) CLN: remove unnecesary _date_check_type (pandas-dev#30932) DOC: Fixture docs in pandas/conftest.py (pandas-dev#30917) CLN: F-strings (pandas-dev#30916) replace syntax with f-string (pandas-dev#30919) BUG: pickle files left behind by tm.round_trip_pickle (pandas-dev#30906) TYP: offsets (pandas-dev#30897) TYP: typing annotations (pandas-dev#30901) WEB: Remove from roadmap moving the docstring script (pandas-dev#30893) WEB: Removing Discourse links (pandas-dev#30890) DOC: Encourage use of pre-commit in the docs (pandas-dev#30864) DEPR: fix missing stacklevel in pandas.core.index deprecation (pandas-dev#30878) CLN: remove unnecessary overriding in subclasses (pandas-dev#30875) RLS: 1.0.0rc0 BUG: validate Index data is 1D + deprecate multi-dim indexing (pandas-dev#30588) ... # Conflicts: # doc/source/whatsnew/v1.0.0.rst
Previously, we stated it as merely optional.
xref #30773, #30814