Skip to content

BUG: concat not copying index and columns when copy=True #31119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 21, 2020

Conversation

fujiaxiang
Copy link
Member

@simonjayhawkins simonjayhawkins added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 18, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fujiaxiang Thanks for the PR.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 18, 2020
@pep8speaks
Copy link

pep8speaks commented Jan 18, 2020

Hello @fujiaxiang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-21 02:12:15 UTC

@fujiaxiang fujiaxiang requested a review from jreback January 19, 2020 03:44
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks fine, ping when green.

@fujiaxiang
Copy link
Member Author

ping

@simonjayhawkins simonjayhawkins merged commit 7ffcf9d into pandas-dev:master Jan 21, 2020
@simonjayhawkins
Copy link
Member

Thanks @fujiaxiang

@fujiaxiang fujiaxiang deleted the concat_index_not_copied branch January 21, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd.concat with copy=True doesn't copy columns index
4 participants