WIP/TST: add dt64tz to indices fixture #31236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #31241 |
jbrockmendel
added
the
Mothballed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomAugspurger @jorisvandenbossche as you can see, the
__array_ufunc__that this implements is an unholy mess. This all came from a much smaller goal: I wanted to add the "datetime-tz" key in tests.indexes.conftest.That broke a test for
np.isfinite, so I started implementingarray_ufunc. Then that broke other ufuncs, and so on and so on.I guess I could just xfail the one isfinite test. In retrospect that would have saved a lot of effort. Woops.
Anyhow, we probably want/need to implement this eventually anyway, so any ideas on how to do it but less awful?
xref #31219.