TST: parametrize tests.indexing.test_float #31855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Feb 11, 2020
| @@ -70,97 +80,107 @@ def test_scalar_error(self, index_func): | |||
| tm.makePeriodIndex, | |||
| ], | |||
| ) | |||
| def test_scalar_non_numeric(self, index_func): | |||
| @pytest.mark.parametrize("klass", [Series, DataFrame]) | |||
There was a problem hiding this comment.
Could be a logical follow up to make a frame_or_series fixture (we already have index_or_series in conftest) as used elsewhere for sure
|
|
||
| f(lambda x: x.loc) | ||
| # setitem | ||
| for l in [slice(3.0, 4), slice(3, 4.0), slice(3.0, 4.0)]: |
There was a problem hiding this comment.
Possible to parametrize this since done in other tests? Maybe need to split off?
There was a problem hiding this comment.
this will need to be split off in a couple of places, will do in a separate pass
|
@jreback gentle ping; lots of PRs are touching this file and it is particularly hard to rebase |
jreback
reviewed
Feb 15, 2020
| @@ -5,6 +5,16 @@ | |||
| import pandas._testing as tm | |||
|
|
|||
|
|
|||
| def gen_obj(klass, index): | |||
There was a problem hiding this comment.
ok, should be turned into a fixture at some point (but understand for now)
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on making our exception-raising more consistent, getting these tests cleaned up will make that easier.