CLN: index related attributes on Series/DataFrame #31953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Thanks @topper-123 generally lgtm. couple of comments. not blockers.
pandas/core/series.py
Outdated
| _AXIS_NAMES = {0: "index"} | ||
| _AXIS_REVERSED = False | ||
| _info_axis_number = 0 | ||
| _info_axis_name = _AXIS_ORDERS[_info_axis_number] |
There was a problem hiding this comment.
i think should either be a property in NDFrame or just be explicit, i.e _info_axis_name = "index"
| _AXIS_REVERSED = False | ||
| _info_axis_number = 0 | ||
| _info_axis_name = _AXIS_ORDERS[_info_axis_number] | ||
| _AXIS_LEN = len(_AXIS_ORDERS) |
topper-123
force-pushed
the
cln_index_related_attributes
branch
from
5912ae7 to
96aee4f
Compare
|
Ok, I've made them strings/ints. |
|
Yea definitely find this easier to follow as well |
WillAyd
approved these changes
Feb 14, 2020
|
Thanks @topper-123 |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #31126. IMO the current approach to adding the index related class attributes is too indirect and therefore unnecessary difficult to follow. Just adding the class attributes directly on the relevant class makes reading the code easier, IMO.
Notice that the types are already defined in pandas/core/generic.py:304-316.