MultiIndex union/intersection with non-object other #32646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 12, 2020
| [self._values, other._ndarray_values], sort=sort | ||
| ) | ||
| if not is_object_dtype(other.dtype): | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
added+green (though no azure)
Closed
jorisvandenbossche
requested changes
Mar 13, 2020
|
gentle ping; we're on the verge of being rid of _ndarray_values |
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM if we call MultiIndex.union with e.g. a Float64Index, we get
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'double'fromlib.fast_unique_multiple. This PR changes that to raise NotImplementedError with a reasonable message, but we could alternatively returnself.to_flat_index().union(other)I prefer making the user do to_flat_index on their own because this seems like something that would often be reached by accident.