Skip to content

PERF: Enable %z in parsing datetime #32984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 29, 2020

Conversation

quangngd
Copy link
Contributor

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an ASV benchmark for this?

Could you add a whatsnew note for this change (1.1)?

@mroeschke mroeschke added Performance Memory or execution speed performance Timezones Timezone data dtype labels Mar 24, 2020
@quangngd
Copy link
Contributor Author

Is this really a performance issue? It feels like an enh to free up a use case that previously have to use workaround. I feel weird putting it under Performance improvements in whatsnew.

@mroeschke
Copy link
Member

Sure you can put in in the enhancement section

@mroeschke mroeschke added this to the 1.1 milestone Mar 29, 2020
@jreback jreback merged commit 5b39709 into pandas-dev:master Mar 29, 2020
@jreback
Copy link
Contributor

jreback commented Mar 29, 2020

very nice @quangngd keep em coming!

@quangngd quangngd deleted the enable-%z-in-parsing-datetime branch March 29, 2020 15:57
@empz
Copy link

empz commented Mar 29, 2020

This is amazing. Thank you!

In which release is this going to be available? 1.1 on August?

@jreback
Copy link
Contributor

jreback commented Mar 29, 2020

likely 1.1 will be soonish - next month or 2

@empz
Copy link

empz commented Apr 17, 2020

Here's a test case notebook showing why pandas should support this:

https://www.kaggle.com/eparizzi/pandas-to-datetime-is-slow

@jreback
Copy link
Contributor

jreback commented Apr 17, 2020

@eparizzi this is already fixed and will be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_datetime() throws ValueError: Cannot pass a tz argument when parsing strings with timezone information.
4 participants