Skip to content

Added test for #5091 (Missing Periods for some DateOffsets) #33195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gorogoroumaru wants to merge 6 commits into from
Closed

Added test for #5091 (Missing Periods for some DateOffsets) #33195

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d656564
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
044968a
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
87a58a1
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
089ed84
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
8972746
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
57c6283
Added a test code for issue 5091
gorogoroumaru Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/tests/series/test_timeseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ def test_asfreq_resample_set_correct_freq(self):
# does .resample() set .freq correctly?
assert df.resample("D").asfreq().index.freq == "D"

def test_period_dateoffset_conversion(self):
Copy link
Member

@mroeschke mroeschke Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put this test in pandas/tests/indexes/period/test_to_timestamp.py

ts = pd.date_range('1/1/2012', periods=4, freq=pd.offsets.BQuarterEnd())
Copy link
Member

@mroeschke mroeschke Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the issue number to this test? # GH 5091

per = ts.to_period()
ts_per = per.to_timestamp()

tm.assert_datetime_array_equal(ts, ts_per)
Copy link
Member

@mroeschke mroeschke Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use use tm.assert_index_equal and rename the variables so it reads tm.assert_index_equal(result, expected)


def test_view_tz(self):
# GH#24024
ser = pd.Series(pd.date_range("2000", periods=4, tz="US/Central"))
Expand Down