Ods loses spaces 32207

[detrout]

• closes read_excel loses spaces on ods #32207
• tests added / passed tests.io.excel.test_reader_spaces
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff (I had to use git diff master though)
• whatsnew entry. It's only a bug fix does it need a whatsnew?

I'm not sure how you make xlsxb files so that test wasn't implement when checking for the different types of space.

There's quite possibly many other ways this parser doesn't handle the odf specification.

[WillAyd]

just pushed an .xlsb copy up; did it with a "Save As" from microsoft excel not sure if supported by other tools

[WillAyd]

Can you also add a whatsnew for 1.1?

[WillAyd]

Can you run black on the changes? Should fix the code checks failure

The linux 37 failure is probably unrelated

[detrout]

While I was filling out the form I ran black, but forgot to push the commit.

And thanks for uploading a xlsb file, I don't have a copy of excel here at home.

[WillAyd]

If you can add a whatsnew note for 1.1 this lgtm - thanks!

[detrout]

How's the description?

[WillAyd]

@jreback care to look?

[jreback]

looks ok, i imagine this would slow down writing a bit?

[WillAyd]

Hmm fair point. @detrout do you mind run asv continuous upstream/master -b io.excel.ReadExcel from the asv_bench directory and posting output here?

Yea in any case fixes a bug so probably not a blocker, but might want to be cognizant of perf impact(s) if any

[detrout]

looks ok, i imagine this would slow down writing a bit?

There's no OpenDocument write support so I don't think it can slow down writes.
I'll need to figure out how to have a stable test environment for running a benchmark

[jreback]

thanks @detrout