Skip to content

BUG: tz_localize needs to invalidate freq #33553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2020
Merged

BUG: tz_localize needs to invalidate freq #33553

merged 4 commits into from
Apr 16, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 14, 2020 •
edited
Loading

Identified when trying to add freq check to assert_index_equal for DatetimeIndex and TimedeltaIndex.

@mroeschke
Copy link
Member

Think this would close #30511

Also what about tz_convert?

@jbrockmendel
Copy link
Member Author

Also what about tz_convert?

I'm pretty sure that for Tick-like freqs, tz_convert should always retain freq. Others are going to be trickier.

@jbrockmendel
Copy link
Member Author

Yes, closes #30511

@mroeschke mroeschke added Bug Frequency DateOffsets Timezones Timezone data dtype labels Apr 16, 2020
@mroeschke mroeschke added this to the 1.1 milestone Apr 16, 2020
@jreback jreback merged commit 6367bd2 into pandas-dev:master Apr 16, 2020
@jreback
Copy link
Contributor

jreback commented Apr 16, 2020

yep thanks. can tz_convert change freq? (I think no)

@jbrockmendel
Copy link
Member Author

can tz_convert change freq? (I think no)

I'm pretty sure that for Tick-like freqs, tz_convert should always retain freq. Others are going to be trickier.

@jbrockmendel jbrockmendel deleted the bug-tz_localize-freq branch April 16, 2020 21:45
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
@jbrockmendel @CloseChoice
BUG: tz_localize needs to invalidate freq (pandas-dev#33553)
87744c8
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
BUG: tz_localize needs to invalidate freq (pandas-dev#33553)
583fd03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Frequency DateOffsets Timezones Timezone data dtype
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

tz_localize creates freq inconsistency on time offset change
3 participants
@jbrockmendel @mroeschke @jreback