TST: prepare for freq-checking in tests.io #33711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Apr 22, 2020
pandas/tests/io/json/test_pandas.py
Outdated
| @@ -226,6 +226,11 @@ def test_roundtrip_empty(self, orient, convert_axes, numpy, empty_frame): | |||
| @pytest.mark.parametrize("numpy", [True, False]) | |||
| def test_roundtrip_timestamp(self, orient, convert_axes, numpy, datetime_frame): | |||
| # TODO: improve coverage with date_format parameter | |||
|
|
|||
| # freq doesnt round-trip | |||
There was a problem hiding this comment.
why don’t u just change this in the fixture? tsframe
There was a problem hiding this comment.
updated per suggestion
There was a problem hiding this comment.
gentle ping; plenty more of these before were done
jreback
approved these changes
Apr 24, 2020
jreback
added
Testing
|
these are fine if u can tag with labels and milestone would be great |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* TST: prepare for freq-checking in tests.io * Update fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on making assert_index_equal check that
freqattrs match. This ports the necessary test changes from tests.io.