Skip to content

BUG: Changing way of applying numpy functions on Series #33775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mproszewska wants to merge 6 commits into from
Closed

BUG: Changing way of applying numpy functions on Series #33775

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d7ee11
BUG: Fix #33492
mproszewska Apr 24, 2020
b6063ab
Fix lint
mproszewska Apr 24, 2020
4d119eb
Remove underscore
mproszewska Apr 24, 2020
f4f4398
Merge branch 'master' into numpy
mproszewska May 10, 2020
a49ddee
Add force_mapping parameter
mproszewska May 10, 2020
04f54e9
Fix doc
mproszewska May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3847,9 +3847,6 @@ def f(x):
f = func

with np.errstate(all="ignore"):
if isinstance(f, np.ufunc):
Copy link
Contributor

@jreback jreback Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we want to do this?
is going to kill perf

Copy link
Contributor Author

@mproszewska mproszewska Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #33492 describes that. I also added test

Copy link
Contributor

@jreback jreback Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I said I am not inclided to accept this w/o proof that this does not kill perf. We likely don't have asv's for this (or even using a np.ufunc in apply).

Now if you add those and either perf is not degraded, or you actually catch the TypeError then I would be ok.

return f(self)

# row-wise access
if is_extension_array_dtype(self.dtype) and hasattr(self._values, "map"):
# GH#23179 some EAs do not have `map`
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/series/test_apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,3 +812,11 @@ def test_apply_to_timedelta(self):
b = Series(list_of_strings).apply(pd.to_timedelta) # noqa
# Can't compare until apply on a Series gives the correct dtype
# assert_series_equal(a, b)

def test_apply_to_numpy_func(self):
s = pd.Series([np.array([0.1, 0.2], dtype=float)])
expected = pd.Series(
[np.array([0.09983341664682815, 0.19866933079506122], dtype=float)]
)
result = s.apply(np.sin)
tm.assert_series_equal(result, expected)