Skip to content

CI: Bump numpydev URL #33968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2020
Merged

CI: Bump numpydev URL #33968

merged 3 commits into from
May 11, 2020

Conversation

TomAugspurger
Copy link
Contributor

NumPy and scipy are uploading their wheels to a new URL.

@TomAugspurger TomAugspurger added this to the 1.1 milestone May 4, 2020
@TomAugspurger TomAugspurger added the CI Continuous Integration label May 4, 2020
@jreback
Copy link
Contributor

jreback commented May 4, 2020

great this is the same URL that we recommended in #33505

cc @alimcmaster1

@jreback
Copy link
Contributor

jreback commented May 4, 2020

merge on green.

@TomAugspurger
Copy link
Contributor Author

We got

numpy                     1.19.0.dev0+8dfaa4a          pypi_0    pypi

That's from 12 days ago, but there are newer wheels available (one from yesterday). Is pip just grabbing the "highest" version number, which happens to be ...8dfaa4a?

@TomAugspurger
Copy link
Contributor Author

@mattip has NumPy's development builds always used .dev0+<git hash> instead of something like .dev0+<increasing-count>.<git hash>? Perhaps I'm just noticing that now.

@jreback
Copy link
Contributor

jreback commented May 4, 2020

@mattip has NumPy's development builds always used .dev0+<git hash> instead of something like .dev0+<increasing-count>.<git hash>? Perhaps I'm just noticing that now.

hmm, that is problematic.

@mattip
Copy link
Contributor

mattip commented May 4, 2020

Looking at the old location I see it used the dates as well, for instance numpy-1.19.0.dev0+20200504031348_58dbafa-cp37-cp37m-linux_x86_64.whl. I must have missed that in the move to azure scripts

@TomAugspurger
Copy link
Contributor Author

@mattip I didn't immediately see where version was set with the old MacPython/numpy-wheels setup. Do you want me to open an issue somewhere as a reminder?

@mattip
Copy link
Contributor

mattip commented May 5, 2020

ping me here again if it is not fixed soonish.

@mattip
Copy link
Contributor

mattip commented May 5, 2020

It is something the uploader did to rename dev wheels.

@jbrockmendel
Copy link
Member

Is this related to the issue breaking the npdev builds?

@mattip
Copy link
Contributor

mattip commented May 5, 2020

@TomAugspurger newer wheels are available. Is there a reason not to delete the old ones?

@TomAugspurger
Copy link
Contributor Author

Thanks! No reason to keep the old ones around I think.

@jbrockmendel are you referring to the

Cython.Compiler.Errors.CompileError: pandas/_libs/reduction.pyx

in https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=34915&view=logs&j=3a03f79d-0b41-5610-1aa4-b4a014d0bc70&t=fe74a338-551b-5fbb-553d-25f48b1836e8&l=443? That looks unrelated from the changes here.

@jreback jreback closed this May 6, 2020
@jreback jreback reopened this May 6, 2020
@jreback
Copy link
Contributor

jreback commented May 6, 2020

triggering to see if this is picked up

@jreback
Copy link
Contributor

jreback commented May 6, 2020

hmm not sure this is picking up the right version.

@jbrockmendel
Copy link
Member

#34050 should fix the non-npdev CI failure

@jreback
Copy link
Contributor

jreback commented May 11, 2020

I think we are still getting the older versions.

@TomAugspurger
Copy link
Contributor Author

Actually I think we're OK. https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=35269&view=logs&j=3a03f79d-0b41-5610-1aa4-b4a014d0bc70&t=fe74a338-551b-5fbb-553d-25f48b1836e8&l=664 has

numpy                     1.19.0.dev0+e664535

Looking at https://anaconda.org/scipy-wheels-nightly/numpy/files, that's from yesterday.

On anaconda.org, it included the full tag numpy-1.19.0.dev0+20200510035734_e664535-cp37-cp37m-manylinux1_i686.whl. Hopefully it's not just by accident that we got the latest wheel :)

@jreback
Copy link
Contributor

jreback commented May 11, 2020

ok great, thanks @TomAugspurger

I guess just let's monitor to make sure we keep getting updates.

@jreback jreback merged commit ac9bc76 into pandas-dev:master May 11, 2020
@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request May 19, 2020
simonjayhawkins pushed a commit that referenced this pull request May 19, 2020
@TomAugspurger TomAugspurger deleted the numpydev-url branch May 19, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants