-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: clarify boxplot whiskers extension #34070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: clarify boxplot whiskers extension #34070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neutrinoceros , agreed that this clarifies things
Co-authored-by: Marco Gorelli <[email protected]>
This doc change is sorely needed. Thanks for doing it! However, your explanation is wrong. The whiskers only ever extend to 1.5*IQR if there happens to be a data point exactly there. Here's how it actually works: https://stackoverflow.com/a/49781675/4691830 . I suggest the following wording:
|
Thanks @joooeey for clarifying this, I applied your suggestion ! |
@joooeey are you sure it's wrong? When the OP wrote
I think they meant that the whiskers only extend there if there's a point there, which I think is what you're saying.
Having said that, thanks for this, I do think your wording is very clear |
@neutrinoceros did you push it? :) I don't (yet) see anything here |
I believe my own wording was correct if you read the "or" and the "within that interval" as an inclusive, which showed my own misunderstanding.
Oops, you're right, the push failed for some reason. |
Great thanks @neutrinoceros |
As I'm getting started with box plots, I found confusing that the
DataFrame.boxplot
docstring didn't mention that whiskers extend at most to 1.5 * IQR away from the box's edges.black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff