TYP: add return types to read_sql|read_sql_query|read_sql_table#34207
Merged
Conversation
WillAyd
reviewed
May 18, 2020
WillAyd
left a comment
WillAyd
left a comment
Member
There was a problem hiding this comment.
looks pretty good. I think the second overload in each case is unnecessary though
| ... | ||
|
|
||
|
|
||
| @overload |
Member
There was a problem hiding this comment.
Hmm I don't think an overload should match the overloaded-signature should it? I think can delete?
Contributor
Author
There was a problem hiding this comment.
Yeah, that's right. I've updated the PR to remove all unneeded overloads.
topper-123
force-pushed
the
typ_sql_functions
branch
from
790129a to
16d478d
Compare
| params=None, | ||
| parse_dates=None, | ||
| chunksize: None = None, | ||
| ) -> Iterator[DataFrame]: |
Member
There was a problem hiding this comment.
are the return types of the two overloads switched? or have a misread the docstring?
Member
There was a problem hiding this comment.
Yea looks like a copy / paste error? The other two funcs look correct.
lgtm outside of this issue
Contributor
Author
|
Yeah, that was a mistake. I've updated. |
Member
|
Thanks @topper-123 |
PuneethaPai
pushed a commit
to PuneethaPai/pandas
that referenced
this pull request
May 22, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds return types to read_sql|read_sql_query|read_sql_table.
I'd like to take on the other pd.read_* functions in follow-ups.