CLN: Move rolling helper functions to where they are used#34269
Merged
WillAyd merged 3 commits intopandas-dev:masterfrom May 21, 2020
Merged
CLN: Move rolling helper functions to where they are used#34269WillAyd merged 3 commits intopandas-dev:masterfrom
WillAyd merged 3 commits intopandas-dev:masterfrom
Conversation
pandas/core/window/rolling.py
Outdated
|
|
||
| def calculate_center_offset(window) -> int: | ||
| """ | ||
| Calculates an offset necessary to have the window label to be centered |
Member
There was a problem hiding this comment.
Sorry to be pedantic :) But should this follow the docstring guide?
The short summary must start with a capital letter, end with a dot, and fit in a single line. It needs to express what the object does without providing details. For functions and methods, the short summary must start with an infinitive verb.
same for the calculate_min_periods docstring
jreback
requested changes
May 20, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. happy to have you de-privatize things if needed (e.g. get_center_of_mass) and/or improve doc-strings. just give a quick pass if you can. ping on green.
added 2 commits
May 20, 2020 21:31
WillAyd
approved these changes
May 21, 2020
Member
|
Thanks @mroeschke |
PuneethaPai
pushed a commit
to PuneethaPai/pandas
that referenced
this pull request
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdded some docstrings as well