Skip to content

DOC: Fix reference, old file was separated last year #34340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2020
Merged

DOC: Fix reference, old file was separated last year #34340

merged 2 commits into from
May 26, 2020
+1 −1

Conversation

phofl
Copy link
Member

@phofl phofl commented May 23, 2020

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

The comment referenced a file deleted last year after separating the tests into a few files. I referenced the correct folder again

@dsaxton dsaxton added Clean Testing pandas testing functions or related to the test suite labels May 25, 2020
dsaxton
dsaxton approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit-pick, otherwise good find / clean-up

@phofl
Copy link
Member Author

phofl commented May 25, 2020

Small nit-pick, otherwise good find / clean-up

Done :)

Thanks

@jreback jreback added this to the 1.1 milestone May 26, 2020
@jreback jreback merged commit 1de24c9 into pandas-dev:master May 26, 2020
@jreback
Copy link
Contributor

jreback commented May 26, 2020

thanks @phofl

@phofl phofl deleted the doc_issue_to_excel branch May 27, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@phofl @jreback @dsaxton @MarcoGorelli