mask based multi-index assignment of column values described #34461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
reviewed
May 30, 2020
jreback
requested changes
Jun 2, 2020
| dfd | ||
|
|
||
| # Setting a single item (recommended) | ||
| dfd.loc[2, 'a'] = 11 |
There was a problem hiding this comment.
can you copy first, like L1876.
There was a problem hiding this comment.
please resolve at will
doc/source/user_guide/indexing.rst
Outdated
| 'three', 'two', 'one', 'six'], | ||
| 'c': np.arange(7)}) | ||
| dfd = dfc.copy() | ||
| # Setting multiple items using a mask (recommended) |
There was a problem hiding this comment.
you don't need the word recommended here (instead you can use it around L1869)
There was a problem hiding this comment.
I put it there as @TomAugspurger suggested it in #34383 if I understood correctly.
There was a problem hiding this comment.
I think Jeff is saying that "This is the correct access method" implies that this is the recommended way to set things.
Perhaps change "This is the correct access method" to something like "Multiple items can be set with .loc and a mask."
There was a problem hiding this comment.
please resolve at will
jreback
added
the
Indexing
jreback
approved these changes
Jun 2, 2020
|
thanks @psteinb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes DOC: Indexing and selecting data and the use of mask/where #34383
passes
black pandasnot sure what this means, will look it up.
passes
git diff upstream/master -u -- "*.py" | flake8 --diff[ ] tests added / passedthis is an PR on documentation only, unit tests are not needed.
[ ] whatsnew entryI think I don't need this as this is a PR related to documentation only.