Skip to content

DOC: add mention of recommended dependencies in users guide #34890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

aidanmontare-edu
Copy link
Contributor

First-time contributor here!

Ian Ozsvald mentioned installing the optional dependencies for pandas in his talk at PyData Amsterdam 2020. Although these are mentioned in the Getting Started section, I though they should be mentioned in the Users Guide, which is where I typically go for pandas information. It seems like many users aren't aware that these dependencies are available to increase performance.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jorisvandenbossche jorisvandenbossche changed the title DOC: add mention of optional dependencies in users guide DOC: add mention of recommended dependencies in users guide Jun 20, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that indeed looks as a good idea to link those from the performance page

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Jun 20, 2020
@MarcoGorelli MarcoGorelli self-requested a review June 20, 2020 12:48
@aidanmontare-edu
Copy link
Contributor Author

Sorry, I meant to make the second commit a separate pull request. Let me figure out how to fix that.

@aidanmontare-edu
Copy link
Contributor Author

Sorry, I meant to make the second commit a separate pull request. Let me figure out how to fix that.

fixed it!

@jorisvandenbossche jorisvandenbossche merged commit cf52834 into pandas-dev:master Jun 20, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

@aidanmontare-edu
Copy link
Contributor Author

I'm glad I could contribute!

wesbarnett pushed a commit to wesbarnett/pandas that referenced this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants