Skip to content

Fix issue #35010: Double requirement given for fsspec #35012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 3 commits into from
Jun 26, 2020
Merged

Fix issue #35010: Double requirement given for fsspec #35012

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618561b
Fixed issue #35010: Double requirement given for fsspec
Jun 26, 2020
ea306c8
Removed changes from whatsnew
Jun 26, 2020
ff1c91a
Added new line in whatsnew v1.1.0.rst
Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ Other
- Bug in :class:`Tick` comparisons raising ``TypeError`` when comparing against timedelta-like objects (:issue:`34088`)
- Bug in :class:`Tick` multiplication raising ``TypeError`` when multiplying by a float (:issue:`34486`)
- Passing a `set` as `names` argument to :func:`pandas.read_csv`, :func:`pandas.read_table`, or :func:`pandas.read_fwf` will raise ``ValueError: Names should be an ordered collection.`` (:issue:`34946`)

- Fixed bug where two different versions of fsspec is mentioned in requirements-dev.txt (:issue:`35010`)
Copy link
Contributor

@jreback jreback Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this as not needed, fsspec was just added in 1.1

.. ---------------------------------------------------------------------------

.. _whatsnew_110.contributors:
Expand Down
1 change: 0 additions & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ dependencies:
# Dask and its dependencies (that dont install with dask)
- dask-core
- toolz>=0.7.3
- fsspec>=0.5.1
- partd>=0.3.10
- cloudpickle>=0.2.1

Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ nbsphinx
pandoc
dask
toolz>=0.7.3
fsspec>=0.5.1
partd>=0.3.10
cloudpickle>=0.2.1
markdown
Expand Down