Skip to content

TST: Test for groupby transform on categorical column #35074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2020
Merged

TST: Test for groupby transform on categorical column #35074

merged 4 commits into from
Jul 1, 2020

Conversation

erfannariman
Copy link
Member

Added test for groupby transform on categorical column

@erfannariman
GH29037
f4e233c 
Added test for groupby transform on categorical column
@erfannariman
GH29037 - changes for black
4b63c9d
WillAyd
WillAyd requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can you move the test to test_categorical.py?

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jul 1, 2020
@erfannariman erfannariman requested a review from WillAyd July 1, 2020 15:52
WillAyd
WillAyd approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @mroeschke

@mroeschke mroeschke merged commit c78c537 into pandas-dev:master Jul 1, 2020
@mroeschke
Copy link
Member

Thanks @erfannariman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categorical column fails in groupby + transform.
3 participants
@erfannariman @mroeschke @WillAyd