Skip to content

PERF: Fix quantile perf regression #35101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonjayhawkins merged 2 commits into from
Jul 3, 2020
Merged

PERF: Fix quantile perf regression #35101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ce575
PERF: Fix quantile perf regression
TomAugspurger Jul 2, 2020
408c2db
Update _validators.py
TomAugspurger Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pandas/util/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,14 +371,13 @@ def validate_percentile(q: Union[float, Iterable[float]]) -> np.ndarray:
ValueError if percentiles are not in given interval([0, 1]).
"""
q_arr = np.asarray(q)
msg = (
"percentiles should all be in the interval [0, 1]."
f"Try {q_arr / 100.0} instead."
)
# Don't change this to an f-string. The string formatting
# is too expensive for cases where we don't need it.
msg = "percentiles should all be in the interval [0, 1]." "Try {} instead."
Copy link
Member

@jbrockmendel jbrockmendel Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra quotation marks probably an artifact of black

if q_arr.ndim == 0:
if not 0 <= q_arr <= 1:
raise ValueError(msg)
raise ValueError(msg.format(q_arr / 100.0))
else:
if not all(0 <= qs <= 1 for qs in q_arr):
raise ValueError(msg)
raise ValueError(msg.format(q_arr / 100.0))
return q_arr