Skip to content

TST: Verify filtering operations on DataFrames with categorical Series #35233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Jul 15, 2020
Merged

TST: Verify filtering operations on DataFrames with categorical Series #35233

jreback merged 2 commits into from
Jul 15, 2020

Conversation

@avinashpancham
Copy link
Contributor

@avinashpancham avinashpancham commented Jul 11, 2020

@jreback jreback added Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves labels Jul 13, 2020
@jreback jreback added this to the 1.1 milestone Jul 13, 2020
jreback
jreback requested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping on green.

pandas/tests/dtypes/test_common.py Outdated
assert isna(result)[0]


def test_categorical_filtering():
Copy link
Contributor

@jreback jreback Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to pandas/tests/indexing/frame/test_categorcal.py

TomAugspurger
TomAugspurger approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved.

@jreback jreback merged commit 1b2f580 into pandas-dev:master Jul 15, 2020
@jreback
Copy link
Contributor

jreback commented Jul 15, 2020

thanks @avinashpancham

fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jul 16, 2020
@avinashpancham @fangchenli
TST: Verify filtering operations on DataFrames with categorical Series (
7ebcac5 
pandas-dev#35233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees

No one assigned

Labels

Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

DataFrame.where method results in ValueError excepted when at least one of the columns is a categorical

3 participants

@avinashpancham @jreback @TomAugspurger