ASV: dt64arr_to_periodarr #35244
Merged
ASV: dt64arr_to_periodarr #35244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.i8values = arr | ||
|
|
||
| def time_dt64arr_to_periodarr(self, size, freq, tz): | ||
| dt64arr_to_periodarr(self.i8values, freq, tz) |
There was a problem hiding this comment.
Is it possible to time the public function/method that in the end uses this instead?
There was a problem hiding this comment.
its possible, yes. but ATM im aiming for thorough coverage of tslibs in isolation, and PRs that dont touch tslibs can skip any of their asvs
There was a problem hiding this comment.
we likely already have coverage at a higher level, these fine-grained asv's are useful.
|
checks are failing...... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.