REF: Simplify Index.copy #35592
Merged
REF: Simplify Index.copy #35592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 6, 2020
jreback
added
Constructors
|
I`ve added tests. |
jreback
approved these changes
Aug 7, 2020
|
lgtm ping on green. |
|
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-08 15:43:16 UTC |
topper-123
force-pushed
the
ref_validate_names
branch
from
c3a5997 to
bbfbda1
Compare
pandas/core/dtypes/common.py
Outdated
| @@ -1732,6 +1732,32 @@ def _validate_date_like_dtype(dtype) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def validate_all_hashable(*args, error_name=None) -> None: | |||
|
Updated. |
jreback
reviewed
Aug 8, 2020
topper-123
force-pushed
the
ref_validate_names
branch
from
63f019b to
c78d99e
Compare
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the use of the
Index.set_namesinIndex.copy, which is a slightly awkward method to use here (it calls_shallow_copy+ is longwinded).This is archieved by tightening up the checks in
_validate_names.