Skip to content

DOC: Add specific Visual Studio Installer instructions #35640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

bdforbes
Copy link
Contributor

@bdforbes bdforbes commented Aug 9, 2020

Notes:

  • The first time I installed the Build Tools it didn't seem to get everything needed, and I had to search around for a while before I could figure out what I'd missed.
  • The advice at python.org is more specific, so I have added that in here. I'm fairly sure that's the minimum required, correct?

Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and clarification.

@bdforbes
Copy link
Contributor Author

I'm actually still having issues building pandas in a fresh Windows VM with just "Windows Universal CRT SDK" and "MSVC v140". I get the error:

fatal error C1083: Cannot open include file: 'basetsd.h'

Searching that error, many people recommend getting the latest "Windows 10 SDK". I also found that I was having errors trying to run cl.exe until I installed the "C++ Build Tools core features". I'm going to continue to test in the VM until I find the combination which works and makes the most sense.

It seems like the instructions could indeed be more specific, if this much effort is required to set up a working development environment.

@bdforbes
Copy link
Contributor Author

I'm going to continue to test in the VM until I find the combination which works and makes the most sense.

In the end I seemed to require these components (starting from the assumption of using MSVC v140):

image

I also had to copy rc.exe and rc.dll from

C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x86

to

C:\Program Files (x86)\Windows Kits\10\bin\x86

as per https://stackoverflow.com/a/45319119/336001.

With this setup, I was able to get pandas to build (with a retry as a few objects failed to compile the first time around). However, I'm not sure I really understand why this particular setup is working. Can anyone weigh in on how to validate a correct Visual Studio Build Tools install?

@bdforbes
Copy link
Contributor Author

I've made a final change to just suggest installing the "C++ build tools" workload. I've just tried this in a fresh VM and pandas builds without any issues.

Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change. Thanks for the thorough investigation. It is surprisingly difficult to get this right on Windows so definitely helpful.

@bashtage
Copy link
Contributor

Also, can you squash to a cingle commit please.

@bdforbes bdforbes force-pushed the vs-build-tools-specific branch from aaf6016 to 72e7bd1 Compare August 30, 2020 13:02
@bdforbes bdforbes force-pushed the vs-build-tools-specific branch from 72e7bd1 to 37db71a Compare August 30, 2020 13:10
Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added the Docs label Aug 31, 2020
@mroeschke mroeschke added this to the 1.2 milestone Aug 31, 2020
@mroeschke mroeschke merged commit 094c7ca into pandas-dev:master Aug 31, 2020
@mroeschke
Copy link
Member

Thanks @bdforbes

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Aug 31, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants