Skip to content

DOC: Fix broken link in cookbook.rst #35729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020
Merged

DOC: Fix broken link in cookbook.rst #35729

merged 1 commit into from
Aug 14, 2020

Conversation

estasney
Copy link
Contributor

The original link Aggregation and plotting time series found in the Pandas Cookbook is broken.

This appears to have been moved to the authors Blog

While the date does not match ( 2013/05 vs 2015/06 ) the contents appear identical. I was able to determine this after viewing the archive at WayBack Machine

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

The original link is broken

While the date does not match ( 2013/05 vs 2015/06 ) the contents appear identical. I was able to determine this after viewing the archive at https://web.archive.org/web/20161202094122/http://nipunbatra.github.io/2015/06/timeseries/
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 14, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estasney for the PR

@jreback jreback merged commit a3f5c6a into pandas-dev:master Aug 14, 2020
@jreback
Copy link
Contributor

jreback commented Aug 14, 2020

thanks @estasney

@estasney estasney deleted the estasney-fix-cookbook-link branch August 14, 2020 22:06
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants