Skip to content

BUG: Unary pos/neg ops on IntegerArrays failing with TypeError #36081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

BUG: Unary pos/neg ops on IntegerArrays failing with TypeError #36081

wants to merge 2 commits into from

Conversation

asishm
Copy link
Contributor

@asishm asishm commented Sep 3, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@asishm asishm mentioned this pull request Sep 3, 2020
Closed
5 tasks
jreback
jreback requested changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have a linked issue? can you add a whatsnew note (you can put in bug fixes for ExtensionArrays) for 1.2

@jreback jreback added NA - MaskedArrays Related to pd.NA and nullable extension arrays Numeric Operations Arithmetic, Comparison, and Logical operations labels Sep 5, 2020
@kokes
Copy link
Contributor

kokes commented Sep 7, 2020

This is a follow-up to #36078, which aimed to address #36063

@simonjayhawkins
Copy link
Member

does this have a linked issue? can you add a whatsnew note (you can put in bug fixes for ExtensionArrays) for 1.2

marking as 1.1.2 for now to match #36063

@simonjayhawkins simonjayhawkins added this to the 1.1.2 milestone Sep 7, 2020
simonjayhawkins
simonjayhawkins requested changes Sep 7, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a release note and test from issue OP? (or comment in test with issue number)

@asishm
Copy link
Contributor Author

asishm commented Sep 7, 2020 •
edited
Loading

sorry. I made an attempt to fix the issue (#36063 ) but then I realized I was trying to do stuff without fully understanding it, I'm not sure if this is even in the right direction at the moment. I can close this PR (put it in draft anyway because I was unsure) if someone else wants a crack at this.

@simonjayhawkins
Copy link
Member

Thanks @asishm no problem, no pressure. will remove milestone.

@simonjayhawkins simonjayhawkins removed this from the 1.1.2 milestone Sep 7, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 7, 2020
Closed
3 tasks
@asishm asishm closed this Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees
No one assigned
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asishm @kokes @simonjayhawkins @jreback