CI: Update version of 'black' #36493
Conversation
MarcoGorelli
force-pushed
the
update-black
branch
from
214e04f to
4a32460
Compare
| exp = SparseArray( | ||
| dense[ | ||
| 4:, | ||
| ] | ||
| ) # noqa: E231 |
There was a problem hiding this comment.
Can the trailing comma be removed here? The explicit ignoring of Missing whitespace after ',', ';', or ':' (E231) suggests this is here on purpose
There was a problem hiding this comment.
Since dense is a 1D array, it should be the same to remove it I think
pandas/io/formats/latex.py
Outdated
| zip(*self.strcols) | ||
| ) # type: ignore[arg-type] |
There was a problem hiding this comment.
| zip(*self.strcols) | |
| ) # type: ignore[arg-type] | |
| zip(*self.strcols) # type: ignore[arg-type] | |
| ) |
There was a problem hiding this comment.
thanks 👍 that solves the typing validation
I'll @ pandas/core / pandas/triage , do you think the rest of the contributors need alerting? I don't think there's that many other people who regularly submit PRs
There was a problem hiding this comment.
I think pandas/core and pandas/triage is probably fine
| 4:, | ||
| ] # noqa: E231 | ||
| exp = SparseArray(dense[4:,]) # noqa: E231 | ||
| res = sparse[4:] |
There was a problem hiding this comment.
since the test is called test_getslice_tuple
| res = sparse[4:] | |
| res = sparse[(slice(4, None),)] |
could be more appropriate?
There was a problem hiding this comment.
Ah, I missed the test name. So then it is probably indeed testing that passing a 1-len tuple is still working for a 1D array. Good catch!
There was a problem hiding this comment.
yes, you're right, thanks, I should've caught that
simonjayhawkins
added
CI
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jorisvandenbossche
changed the title
|
Thanks @MarcoGorelli ! |
|
@pandas-dev/pandas-core @pandas-dev/pandas-triage reminder/notification to update |
closes #35925
Not many files left so am making a PR to close this off