-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fix for #37454: allow reversed axis when plotting with TimedeltaIndex #37469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theavey for the PR!
A suggestion re: wording on the whatsnew note, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the actual plotting tests from the OP (both working and non-working)
pandas/tests/plotting/tests_series.py is prob fine.
pls merge master and ping on green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with comment. ping on greenish.
@jreback, looks like everything is working except some unrelated failures with FutureWarning. |
@jreback, I think this is good to go |
thanks @theavey very nice |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff