BUG: Fix for #37454: allow reversed axis when plotting with TimedeltaIndex - #37469
Merged
Conversation
theavey
changed the title
arw2019
approved these changes
Oct 29, 2020
jreback
requested changes
Oct 31, 2020
jreback
left a comment
jreback
left a comment
Contributor
There was a problem hiding this comment.
can you add the actual plotting tests from the OP (both working and non-working)
pandas/tests/plotting/tests_series.py is prob fine.
pls merge master and ping on green.
jreback
requested changes
Nov 2, 2020
jreback
left a comment
jreback
left a comment
Contributor
There was a problem hiding this comment.
lgtm with comment. ping on greenish.
Contributor
Author
|
@jreback, looks like everything is working except some unrelated failures with FutureWarning. |
Contributor
Author
|
@jreback, I think this is good to go |
jreback
approved these changes
Nov 18, 2020
Contributor
|
thanks @theavey very nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff