Skip to content

BUG: Fix for #37454: allow reversed axis when plotting with TimedeltaIndex #37469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 18, 2020
Merged

Conversation

theavey
Copy link
Contributor

@theavey theavey commented Oct 28, 2020

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theavey for the PR!

A suggestion re: wording on the whatsnew note, otherwise LGTM

@theavey theavey changed the title Fix for #37454: allow reversed axis when plotting with TimedeltaIndex BUG: Fix for #37454: allow reversed axis when plotting with TimedeltaIndex Oct 29, 2020
@jreback jreback added this to the 1.2 milestone Oct 31, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the actual plotting tests from the OP (both working and non-working)
pandas/tests/plotting/tests_series.py is prob fine.
pls merge master and ping on green.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with comment. ping on greenish.

@theavey
Copy link
Contributor Author

theavey commented Nov 2, 2020

@jreback, looks like everything is working except some unrelated failures with FutureWarning.

@theavey
Copy link
Contributor Author

theavey commented Nov 12, 2020

@jreback, I think this is good to go

@jreback jreback merged commit 79a184a into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

thanks @theavey very nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError raised when plottting reversed fixed-frequency TimedeltaIndex
3 participants