TST: split up tests/plotting/test_frame.py into subdir & modules #34769 #37538
Conversation
|
you could start with groupby, subplots, colors just look for a grouping of tests that are common and move them. i would recommend merge master on this and can merge, then do followup PRs to extract. |
jreback
added
Testing
|
@jreback OK thanks. I think I figured out what to do with the tests. |
|
make sure to |
of test_frame.py to test_frame_color.py
|
Hello @Mikhaylov-yv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-02 17:32:53 UTC |
of test_frame.py to test_frame_groupby.py and test_frame_subplots.py
# Conflicts: # pandas/tests/plotting/frame/test_frame.py
|
Am I doing the right thing? |
|
yes this looks fine. can you show the before / after test runs for this dir (make sure test counts don't change). ping when ready. btw no need to do anymore in this PR, can followup with others. ping on green. |
of test_frame.py to test_frame_subplots.py
* TST/REF: move remaining setitem tests from test_timeseries * TST/REF: rehome test_timezones test * move misplaced arithmetic test * collect tests by method * move misplaced file
…stype() from 'object' (#35973)
) * BUG/REF: read_csv shouldn't close user-provided file handles * get_handle: typing, returns is_wrapped, use dataclass, and make sure that all created handlers are returned * remove unused imports * added IOHandleArgs.close * added IOArgs.close * mostly comments * move memory_map from TextReader to CParserWrapper * moved IOArgs and IOHandles * more comments Co-authored-by: Jeff Reback <[email protected]>
…ate labels (#36814) * DOC: add example & prose of slicing with labels when index has duplicate labels #36251 * DOC: proofread the sentence. Co-authored-by: Jun Kudo <[email protected]>
"columns(s)" sounded odd, I believe it was supposed to be just "column(s)".
of test_frame.py to test_frame_groupby.py, test_frame_subplots.py, test_frame_color.py
|
Oh no. I did something wrong. Probably better to create a new PR and delete this one? |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI moved the file to a new directory.
What is the best structure for this folder?