Skip to content

REF: de-duplicate IntervalIndex compatiblity checks #37916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

REF: de-duplicate IntervalIndex compatiblity checks #37916

merged 1 commit into from
Nov 18, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jorisvandenbossche
jorisvandenbossche approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@jreback jreback added the Interval Interval data type label Nov 18, 2020
@jreback jreback added this to the 1.2 milestone Nov 18, 2020
@jreback jreback added the Refactor Internal refactoring of code label Nov 18, 2020
@jreback jreback merged commit 687e756 into pandas-dev:master Nov 18, 2020
@jbrockmendel jbrockmendel deleted the ref-ii-cmp branch November 18, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Interval Interval data type Refactor Internal refactoring of code
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jorisvandenbossche @jreback