ENH: str extract with default value

[erfannariman]

• closes ENH: add default value to str.extract #38001
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @erfannariman! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-10 09:42:30 UTC

[erfannariman]

@jreback any chance we can decide what we want to do with this PR? If you think this change is not needed, It's fine for me to close it.

[jreback]

i'd really like a real-world usecase of this. The work-aroudn is actually very simpler (even simpler that what you posted), so not convinced this all that useful. that said prob doesnt' hurt.

@erfannariman yeah i guess this is ok, can't hurt. rename default -> fill_value (as that is the term we use else where) and move the note to 1.3.

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

[datapythonista]

@erfannariman closing this, if you think of a real case for this, happy to reopen. But agree with Jeff that even if this makes sense, adding more complexity to pandas for a reasonable use case that no user may ever face, it's not worth

[simonjayhawkins]

@erfannariman closing this, if you think of a real case for this, happy to reopen. But agree with Jeff that even if this makes sense, adding more complexity to pandas for a reasonable use case that no user may ever face, it's not worth

technically it's probably straightforward, we already pass na in other methods and handle it in the wrap_result and _str_map methods (as na_value)

i'm not sure a real world case is required to justify this as accepting a na parameter would make str.extract consistent with other str accessor methods.

[simonjayhawkins]

I'll reopen this, but I think this enhancement should wait until after str.extract is dispatched to array and the _wrap_result and str_map methods are re-used. #41372

[simonjayhawkins]

@erfannariman can you resolve conflicts and can take another look

[simonjayhawkins]

@erfannariman closing as stale. ping if you want to pick this up again.